Naming Convention Detector #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirtixs
force-pushed
the
feature/naming-convention
branch
2 times, most recently
from
4f8713e
to
35a0b6c
Compare
kirtixs
force-pushed
the
feature/naming-convention
branch
from
35a0b6c
to
495de91
Compare
kirtixs
force-pushed
the
feature/naming-convention
branch
from
ac90ca9
to
ed89bf3
Compare
kirtixs
force-pushed
the
feature/naming-convention
branch
from
ed89bf3
to
a0cb5ec
Compare
montyly
requested changes
Oct 18, 2018
| ARGUMENT = 'naming-convention' | ||
| HELP = 'naming convention violations' | ||
| IMPACT = DetectorClassification.INFORMATIONAL | ||
| CONFIDENCE = DetectorClassification.INFORMATIONAL |
There was a problem hiding this comment.
We can probably set the Confidence to HIGH?
|
Thanks for your contribution, the PR looks good! |
montyly
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a detector for naming convention violations.
fixes #24
Some tests violate naming conventions and I had to update the expected number of results in order for the tests to succeed.
I think it is better to limit each test case to only run the detector for which the test was made for.