Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removing redundant print statements; fixing detect flow #202

Merged
merged 5 commits into from
Dec 19, 2023
Merged

refactor: removing redundant print statements; fixing detect flow #202

merged 5 commits into from
Dec 19, 2023

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Dec 15, 2023 •
edited
Loading

Proposed changes

Hotfixing bare minimum set of bugs required to make detect command usable in algokit cli context.

  • Including all detectors by default otherwise --exclude flag doesn't work)
  • Trimming detector names
  • Removing redundant print statements

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aorumbayev aorumbayev mentioned this pull request Dec 15, 2023
Open
@montyly montyly changed the base branch from main to dev December 19, 2023 14:09
@montyly
Copy link
Member

montyly commented Dec 19, 2023

that's great, thanks @aorumbayev

@montyly montyly merged commit 6240ba6 into crytic:dev Dec 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S3v3ru5 S3v3ru5 Awaiting requested review from S3v3ru5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aorumbayev @CLAassistant @montyly