Make tealer compatible with python 3.12 #209
Conversation
montyly
changed the title
|
What this PR contains:
|
|
Hey @montyly any updates on when this is expected to be merged? |
|
Warning Rate Limit Exceeded@montyly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 51 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on modernizing Python workflows and dependency management across various GitHub Actions, including transitioning to Python 3.9, enhancing test coverage with a matrix strategy for multiple Python versions, and adopting Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
pyproject.tomlis excluded by:!**/*.toml
Files selected for processing (8)
- .github/workflows/darglint.yml (1 hunks)
- .github/workflows/linter.yml (1 hunks)
- .github/workflows/pytest.yml (2 hunks)
- .github/workflows/pytest310.yml (1 hunks)
- .github/workflows/tests.yml (1 hunks)
- setup.py (1 hunks)
- tealer/main.py (2 hunks)
- tealer/utils/command_line/common.py (4 hunks)
Additional comments: 8
setup.py (1)
- 1-3: Ensure all necessary configurations previously in
setup.pyare correctly specified inpyproject.toml..github/workflows/darglint.yml (1)
- 20-23: Change aligns with PR objectives to drop support for Python 3.8.
.github/workflows/tests.yml (1)
- 21-36: Change correctly implements the intended update to test across Python versions 3.9 to 3.12.
.github/workflows/pytest310.yml (1)
- 32-32: Change aligns with modern Python packaging practices.
.github/workflows/pytest.yml (1)
- 18-60: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-57]
Changes correctly implement the intended updates, including the workflow name change and the introduction of a matrix strategy for Python versions 3.9 to 3.12.
.github/workflows/linter.yml (1)
- 26-29: Change aligns with PR objectives to drop support for Python 3.8.
tealer/utils/command_line/common.py (1)
- 90-115: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [58-111]
Changes correctly implement the intended updates to use
importlib.metadataand improve compatibility across different Python versions with the_get_entry_pointsfunction.tealer/__main__.py (1)
- 74-74: Change aligns with PR objectives and modern Python practices by using
importlib.metadata.versionfor retrieving version information.
|
@aorumbayev : it's available on pypi. The support for 3.12 took us a bit more time than anticipated |
Summary by CodeRabbit
python setup.py installtopip install .for a more standard approach to installing dependencies.pkg_resources.requirewithimportlib.metadata.versionfor version retrieval, enhancing the efficiency of internal operations.importlib.metadata, improving compatibility with different Python versions.