Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: py3.12 support (#1) #207

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix: py3.12 support (#1) #207

merged 2 commits into from
Dec 22, 2023

Conversation

aorumbayev
Copy link
Contributor

Proposed changes

  • SImilar to Python 3.12 compatibility issues algorand/pyteal#712, adds setuptools into requirements explicitly since 3.12 no longer includes it by default. Required in order to make tealer work with python 3.12 based environments and for us to release the integration on algokit

setup.py Outdated Show resolved Hide resolved
@montyly
Copy link
Member

montyly commented Dec 22, 2023

Good catch, thanks for the PR

@montyly montyly merged commit a720ec4 into crytic:main Dec 22, 2023
7 checks passed
@aorumbayev
Copy link
Contributor Author

@montyly any chance you can let us know once you propagate this on pypi as well?

@neilcampbell
Copy link

@montyly @S3v3ru5 Sorry to be a pain, just wanted to ask if you'd be able to publish an update to the pypi package including this change?

@montyly
Copy link
Member

montyly commented Dec 28, 2023

@aorumbayev @neilcampbell: yes we will make a release next week (right after our holidays break ;) )

@neilcampbell
Copy link

@montyly Amazing, thank you!

@aorumbayev
Copy link
Contributor Author

Hey @montyly happy new year! :-)

Just checking in if you managed to get to release this on pypi? Thats the only item blocking us at the moment from release

@aorumbayev
Copy link
Contributor Author

Hey @montyly , just checking in again, any updates on publishing the latest pypi version?

@montyly
Copy link
Member

montyly commented Jan 22, 2024

@aorumbayev : sorry for the delay on this.

We released tealer 0.1.1, but actually the support for 3.12 is still weak, and we are improving it as a priority right now (#209), and will release 0.1.2 asap

@aorumbayev
Copy link
Contributor Author

Hey @montyly it seems like the remaining 3.12 changes are mostly on the ci/cd side for tealer, i will test the 0.1.1 against our latest PRs if they work as expected in 3.12 environments we will go ahead and release integration on algokit. Once you have further 3.12 support changes in place just ping us in this thread and we will simply bump the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants