Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command to show expected output #36

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

MekalBoy
Copy link

@MekalBoy MekalBoy commented Dec 5, 2023

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Calling strace -e clone ./sum_array_threads 2 would not show the clone3 syscall.
Replacing clone with clone,clone3 in both commands allows the syscalls to display as expected.

A small typo has also been fixed.

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is almost OK. You only need to squash your commits into a single one. First run git rebase -i HEAD~2 then in the rebase menu, change the word pick from the last line into s, then save and exit. This will open another editor where you'll be see the messages of the 2 commits in this PR merged into a single one. There you'll need to delete the second commit message so that only the first one remains. Then use git push -f to update the remote branch.

@github-actions github-actions bot added area/content Content (Markdown) update topic/compute Related to "Compute" chapter labels Dec 6, 2023
Only using `-e clone` would not show the `clone3` syscall for threads.
Replacing `clone` with `clone,clone3` in both commands solves the issue.

A small typo has also been fixed.

Signed-off-by: Tache Robert Andrei <tacheandu@gmail.com>
@MekalBoy
Copy link
Author

MekalBoy commented Dec 6, 2023

The two commits have been squashed into one and the commit description has been updated to keep a maximum of 75 characters per line.

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks!

@teodutu teodutu merged commit d6a1753 into cs-pub-ro:main Dec 6, 2023
1 of 3 checks passed
@MekalBoy MekalBoy deleted the computefix branch December 7, 2023 12:12
@teodutu teodutu added student-contrib Fix or improvement made by a student kind/improve Improve / Update existing content / item labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/content Content (Markdown) update kind/improve Improve / Update existing content / item student-contrib Fix or improvement made by a student topic/compute Related to "Compute" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants