Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docs link for ocmproviderauthorizer #3532

Open
12 tasks
michielbdejong opened this issue Dec 8, 2022 · 2 comments
Open
12 tasks

Missing docs link for ocmproviderauthorizer #3532

michielbdejong opened this issue Dec 8, 2022 · 2 comments

Comments

@michielbdejong
Copy link
Contributor

michielbdejong commented Dec 8, 2022

@michielbdejong
Copy link
Contributor Author

I see for instance https://github.com/cs3org/reva/blob/af8fe04/pkg/ocm/provider/authorizer/mentix/mentix.go#L81 has 'docs' in a comment; that suggests that we could maybe even auto-generate these docs from code comments?

That would be best of course!

@labkode
Copy link
Member

labkode commented Dec 19, 2022

@michielbdejong yes the doc gets automatically generated from the code, but the code is missing the comments, I'll address some of these with my team on our return from holidays. In the mean time, anyone can start adding comments to the configuration of these services and the makefile has the code to generate the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants