Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting favorites, mtime and a temporary etag #1393

Merged
merged 5 commits into from
Jan 14, 2021

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jan 8, 2021

We now let the ocis driver

  • persist favorites
  • set temporary etags
  • set the mtime as arbitrary metadata
  • changelog

Signed-off-by: Jörn Friedrich Dreyer jfd@butonic.de

@butonic butonic requested a review from labkode as a code owner January 8, 2021 17:35
@update-docs
Copy link

update-docs bot commented Jan 8, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic marked this pull request as draft January 8, 2021 17:43
@butonic butonic force-pushed the ocis-favorites-etags-mtime-metadata branch from d364209 to 733d40a Compare January 8, 2021 19:35
@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2021

This pull request introduces 1 alert when merging 2ab71a9 into f2b63bf - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the ocis-favorites-etags-mtime-metadata branch from 2745d9c to f4b5c93 Compare January 14, 2021 11:35
@butonic butonic marked this pull request as ready for review January 14, 2021 12:16
@labkode labkode merged commit c212a4e into cs3org:master Jan 14, 2021
@butonic butonic deleted the ocis-favorites-etags-mtime-metadata branch January 14, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants