fix: chunked upload of existing file creates new version #1899
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
This pull request introduces 13 alerts when merging 0cc96aa into 7df477f - view on LGTM.com new alerts:
|
C0rby
force-pushed
the
chunked-upload-versions
branch
from
0cc96aa
to
2fbbc74
Compare
C0rby
force-pushed
the
chunked-upload-versions
branch
from
2fbbc74
to
36f3efa
Compare
|
This pull request introduces 13 alerts when merging 36f3efa into 7df477f - view on LGTM.com new alerts:
|
| @@ -360,6 +358,33 @@ func (fs *Decomposedfs) GetUpload(ctx context.Context, id string) (tusd.Upload, | |||
| }, nil | |||
| } | |||
|
|
|||
| // lookupNode looks up nodes by path. | |||
| // This method can also handle lookups for paths which contain chunking information. | |||
There was a problem hiding this comment.
could you add a reason how this function differs from the one in the lookup interface? Do you think other implementations of the decomposedfs need the same handling / detection of chunked paths? should fs.lu.NodeFromPath maybe get a parameter to handle chunked paths? why not add a fs.lu.NodeFromChunkedPath and refactor the two functions to share more code?
There was a problem hiding this comment.
Ah, now I see that you are calling fs.lu.NodeFromPath in lookupNode ... nevermind my comment ;-)
Chunked uploads didn't create a new version, when the file to upload already existed.