subcommands #6
Merged
subcommands #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmalan
requested changes
Nov 17, 2020
ide50/__main__.py
Outdated
| """Print container port mappings and URL""" | ||
| # List port mappings | ||
| print(ports(container)) | ||
| print(_("Running on {}. Run `ide50 -S` to stop.").format( |
There was a problem hiding this comment.
Good catch! Fixed. Thanks!
| repository, tag = image.split(":") if ":" in image else (image, "latest") | ||
| if "/" not in repository: | ||
| repository = "library/" + repository | ||
|
|
There was a problem hiding this comment.
I typically use a blank line after ifs, fors, groups of related statements, multi-line statements, etc to visually separate them https://www.python.org/dev/peps/pep-0008/#blank-lines.
| pass | ||
| except AssertionError: | ||
| print(_("A newer version is available. Run `pip3 install --upgrade ide50` to upgrade.")) | ||
|
|
| except subprocess.CalledProcessError: | ||
|
|
||
| # Publish all exposed ports to random ports | ||
| try: | ||
| container = subprocess.check_output([*cmd, "--publish-all", args.image]).decode().rstrip() | ||
| container = subprocess.check_output([*cmd, "--publish-all", |
| print(ports(container)) | ||
| print(_("Running on {}. Run `ide50 -S` to stop.").format(f"http://{ports(container.split()[0], C9_PORT)}/")) | ||
|
|
||
| container_info(container) |
| def pull(image): | ||
| """Pull image as needed.""" | ||
| try: | ||
| sys.exit(0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.,