Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the DocumentNotes section #35

Closed
cgi1 opened this issue Jan 14, 2022 · 1 comment · Fixed by #38
Closed

Implement the DocumentNotes section #35

cgi1 opened this issue Jan 14, 2022 · 1 comment · Fixed by #38

Comments

@cgi1
Copy link
Contributor

cgi1 commented Jan 14, 2022

EPIC: #10

CVRF 1.1 view

grafik

CVRF 1.2

[Oasis v1.2 -> 4.6 Document Notes]http://docs.oasis-open.org/csaf/csaf-cvrf/v1.2/cs01/csaf-cvrf-v1.2-cs01.html#_Toc493508888)

Oasis implementation view CSAF v2

Field Definition 3.1.5 Notes Type

changed 1.2 -> 2.0 spec:

changed 1.2 -> 2.0 spec:

E.1 Newly introduced elements

-- no new elements

E.2 Changed elements

-- no changed elements

E.4 Mapped elements

| /document/notes | /cvrf:cvrfdoc/cvrf:DocumentNotes | |
| /document/notes[i] | /cvrf:cvrfdoc/cvrf:DocumentNotes/cvrf:Note[i+1] | |
| /document/notes[i]/audience | /cvrf:cvrfdoc/cvrf:DocumentNotes/cvrf:Note[i+1]/@Audience | |
| /document/notes[i]/category | /cvrf:cvrfdoc/cvrf:DocumentNotes/cvrf:Note[i+1]/@Type | |
| /document/notes[i]/text | /cvrf:cvrfdoc/cvrf:DocumentNotes/cvrf:Note[i+1]/text() | |
| /document/notes[]/title | /cvrf:cvrfdoc/cvrf:DocumentNotes/cvrf:Note[i+1]/@Title | |

Example Test fiie

@cgi1 cgi1 self-assigned this Jan 18, 2022
cgi1 pushed a commit that referenced this issue Jan 18, 2022
@cgi1
Copy link
Contributor Author

cgi1 commented Jan 18, 2022

Clarify logging semantics, then ready for review + merge.

cgi1 pushed a commit that referenced this issue Jan 23, 2022
#24 with #35 -> Only throw warning if args->force is enabled; otherwise error.
@cgi1 cgi1 mentioned this issue Jan 23, 2022
cgi1 pushed a commit that referenced this issue Jan 24, 2022
#24 with #35 -> Only throw warning if args->force is enabled; otherwise error.
cgi1 pushed a commit that referenced this issue Jan 24, 2022
cgi1 pushed a commit that referenced this issue Jan 24, 2022
sustefil pushed a commit that referenced this issue Jan 28, 2022
* Implementing document_notes.py #35

* Remove my little helper function.

* Improve warning document notes (c6c6301#r64143712)

* #24 -> Implement force flag and push it to the base handler
#24 with #35 -> Only throw warning if args->force is enabled; otherwise error.

* #24 with #35 -> Cleaner implementation of boolean switch for force.

* notes None check

* #24 -> Implement force flag and push it to the base handler
#24 with #35 -> Only throw warning if args->force is enabled; otherwise error.

* Q/S of boolean config.yaml items

* #38 improvement; #35 issue; Resolving #38 (comment)

* Integrated logging for force flag in DocumentTracking

* smaller fixes

* #24 #35 -> Only throw error if args->force is enabled; otherwise critical_exit.

* Add force_update_revision_history to config validation
Fix relative input for critical_exit in Document Notes

* Log level set to error instead of critical_exit.

* Log level set to error instead of critical_exit for document_tracking.

Co-authored-by: cgi <cgi@gitlab.com>
Co-authored-by: mzp <marek.zpevacek@t-mobile.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant