Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): reduce chakra-ui dep size #60

Merged
merged 8 commits into from
Mar 3, 2022

Conversation

CaitlinSweeney
Copy link
Contributor

@CaitlinSweeney CaitlinSweeney commented Feb 25, 2022

  • chore: remove @chakra-ui/react and add only import @chakra-ui components
  • feat: remove the TypeScript warning on chakra.div, in Option component. Wrapped in Box component to update the isDisabled prop

@csandman csandman self-requested a review February 25, 2022 20:00
csandman and others added 5 commits February 25, 2022 16:03
Update the peer deps' versions so they play nicely with multiple versions of Chakra UI
Instead of using an extra wrapper for the `Option` component, pass the proper aria-disabled and data-disabled props instead
This is outside of the scope of what this PR is for, and the styling doesn't line up with the original react-select package
This can also easily be accomplished with the `chakraStyles` prop
@csandman csandman merged commit a8db539 into csandman:main Mar 3, 2022
@csandman
Copy link
Owner

csandman commented Mar 3, 2022

Thanks again for the PR! It has been merged and released in v3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants