Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New react-select version + Minor tweaks #84

Merged
merged 10 commits into from
Apr 14, 2022
Merged

Conversation

csandman
Copy link
Owner

  • Update react-select to 5.3.0
  • Update all dev dependencies:
 @babel/core                        ^7.17.7  →  ^7.17.9     
 @chakra-ui/form-control             ^1.5.9  →   ^1.6.0     
 @chakra-ui/layout                   ^1.7.7  →   ^1.8.0     
 @chakra-ui/menu                     ^1.8.9  →  ^1.8.11     
 @chakra-ui/system                  ^1.11.2  →  ^1.12.1     
 @emotion/react                     ^11.8.2  →  ^11.9.0     
 @types/react                      ^17.0.40  →  ^18.0.5     
 @typescript-eslint/eslint-plugin   ^5.15.0  →  ^5.19.0     
 @typescript-eslint/parser          ^5.15.0  →  ^5.19.0     
 concurrently                        ^7.0.0  →   ^7.1.0     
 eslint                             ^8.11.0  →  ^8.13.0     
 eslint-config-airbnb-typescript    ^16.1.3  →  ^17.0.0     
 eslint-plugin-import               ^2.25.4  →  ^2.26.0     
 eslint-plugin-react-hooks           ^4.3.0  →   ^4.4.0     
 prettier                            ^2.6.0  →   ^2.6.2     
 react                              ^17.0.2  →  ^18.0.0     
 react-dom                          ^17.0.2  →  ^18.0.0     
 typescript                          ^4.6.2  →   ^4.6.3
  • Change the names on all the default chakra style props for each sub-component to the long form version of their names
    • This is meant to increase consistency between all style props and the readability of the code
    • This shouldn't affect overriding these props as later props get priority
  • The isReadOnly and isRequired props will not be forwarded from a wrapping form control to the <input> component
    • Only aria-required is added to the input, as it will not actually be filled when submitting a form so it should not block the submission when it is blank
  • Fix the type errors caused by the generics on the MultiValue components
  • Add the class-name-prefix--has-value class to the SelectContainer component when there is a value selected

@csandman csandman merged commit 8675821 into main Apr 14, 2022
@csandman csandman deleted the csandman/new-react-select branch April 14, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant