git binary patch explore #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
2 tasks
cscorley
reviewed
Jan 22, 2023
| @@ -248,7 +256,6 @@ def parse_git_header(text): | |||
| # if we go through all of the text without finding our normal info, | |||
| # use the cmd if available | |||
| if cmd_old_path and cmd_new_path and old_version and new_version: | |||
| print("returning from dumb path") | |||
cscorley
reviewed
Jan 22, 2023
src/whatthepatch/patch.py
Outdated
| @@ -914,3 +921,87 @@ def parse_rcs_ed_diff(text): | |||
| return changes | |||
|
|
|||
| return None | |||
|
|
|||
|
|
|||
| def parse_binary_diff(text): | |||
There was a problem hiding this comment.
I think if this only handles git files, it should be named parse_git_binary_diff. I can change this myself before release, or you can if you get back to it before I merge.
|
@babenek thanks! Is this ready to merge? I just want to make sure since the title contains "explore" and the branch is named "tmp" 😄 |
|
@cscorley, |
|
Thanks! As always, your contributions are very appreciated. |
cscorley
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request fixes #4 partially.
Suppose, we have diff only (without original repo), then only
literaltype can be valuable.