-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git binary patch explore #53
Conversation
@@ -248,7 +256,6 @@ def parse_git_header(text): | |||
# if we go through all of the text without finding our normal info, | |||
# use the cmd if available | |||
if cmd_old_path and cmd_new_path and old_version and new_version: | |||
print("returning from dumb path") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
src/whatthepatch/patch.py
Outdated
@@ -914,3 +921,87 @@ def parse_rcs_ed_diff(text): | |||
return changes | |||
|
|||
return None | |||
|
|||
|
|||
def parse_binary_diff(text): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if this only handles git files, it should be named parse_git_binary_diff
. I can change this myself before release, or you can if you get back to it before I merge.
@babenek thanks! Is this ready to merge? I just want to make sure since the title contains "explore" and the branch is named "tmp" 😄 |
@cscorley, |
Thanks! As always, your contributions are very appreciated. |
The pull request fixes #4 partially.
Suppose, we have diff only (without original repo), then only
literal
type can be valuable.