Allow dimensionless time units #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcflugen Is "-" not accepted by udunits? We used "-" all over the place for a default unspecified time unit. |
|
@mdpiper Correct, "-" is not a valid unit. "" or "1" are the symbols to use for dimensionless units. We don't have a way of specifying a generic unit of time. |
|
@mdpiper We also don't handle the case of a model that doesn't vary with time and so doesn't have time units at all. Maybe the string, |
|
@mcflugen Yeah, I agree that I'll note this info in the docs for get_time_units. |
mdpiper
added a commit
to csdms/bmi
that referenced
this pull request
Sep 10, 2020
This reflects a discussion in csdms/bmi-tester#22. Also changed formatting in the docs to use a monospace font and quotes around the units to set them off from the text.
mdpiper
added a commit
to csdms/bmi
that referenced
this pull request
Sep 10, 2020
This reflects a discussion in csdms/bmi-tester#22. Also changed formatting in the docs to use a monospace font and quotes around the units to set them off from the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows dimensionless units (i.e. "", "1", but not "-") to be used as time units for a BMI as returned by get_time_units.