Add function to get node coordinate units #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdpiper
changed the title
|
@mcflugen This PR is updated according to our discussion in December. Let me know what you think. Also, would you prefer this be merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new BMI function, get_grid_coordinate_units, that allows a BMI user to get the units of each grid coordinate.
The function is patterned on the existing get_var_units function, which accepts a variable name as a string and returns the units of the variable as a string. For get_grid_coordinate_units, the input name is a coordinate: currently "x", "y", or "z", but this could be extended as BMI is extended to handle more dimensions (see #88).
This change is part of the BMI 2.1 Milestone. The BMI version has been incremented to v2.1-beta.
This fixes #87. See #90 (comment) for some discussion on this new function.