Create PSUADE MOAT method #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not have "study" in it
|
@mdpiper I'm getting close to doing some additional work on Dakotathon (adding a calibration method). Before I start I'd appreciate any feedback on how I implemented this method. Should I do the new method in a vastly different way? |
|
@kbarnhart I'll start reviewing this PR this week. (I'm in the midst of writing a report for NSF due Friday.) I'm sorry I've taken so long in getting to this. |
|
@mdpiper no worries. good luck with report! |
|
@kbarnhart This PR looks great! I'll merge it. Thank you so much for contributing to this project! |
This was referenced Jul 27, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #60 by creating a dakotathon implementation of the PSUADE MOAT method.
@mdpiper I've done my best to follow your prior work in developing tests. If there are standard method tests that I've missed, please let me know and I'll write them.