Py source consistency using isort and pyupgrade tools, rm unused imports #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused shebangs on non-executable module and test files
mwtoews
force-pushed
the
isort-pyupgrade-etc
branch
from
d4c3ffa
to
c75b1e1
Compare
mdpiper
approved these changes
Feb 3, 2023
|
@mwtoews Thank you for this contribution, and I apologize for getting to it so late! @mcflugen I'm going to merge this PR despite the failing tests, since the changes here don't have any bearing on the tests. I've identified the reasons for the failing tests -- #162, #164, and permamodel/permamodel#72 -- and I have a workaround for them in a separate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is further clean-up, mostly automated with a few manual edits. Using isort, pyupgrade, also
flake8 --select F401to identify unused imports.Also remove unused shebangs on non-executable module and test files.