Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

dx: add CONTRIBUTING.md file #78

Merged
merged 10 commits into from
Aug 22, 2022

Conversation

jideabdqudus
Copy link
Contributor

@jideabdqudus jideabdqudus commented Aug 15, 2022

Closes #71

  • Created and wrote the Contributing Doc to assist with developers experience.

@vercel
Copy link

vercel bot commented Aug 15, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel.

@ykdojo first needs to authorize it.

Copy link
Collaborator

@ykdojo ykdojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but it's a lot to review in one go.

Any chance you could break it down to much smaller pieces and send individual PRs for them?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jideabdqudus
Copy link
Contributor Author

This is a good start, but it's a lot to review in one go.

Any chance you could break it down to much smaller pieces and send individual PRs for them?

Do I close this PR and send new PRs as individual chunks? Or how do I go about this

@rohitdasu
Copy link
Contributor

This is a good start, but it's a lot to review in one go.
Any chance you could break it down to much smaller pieces and send individual PRs for them?

Do I close this PR and send new PRs as individual chunks? Or how do I go about this

Hi @jideabdqudus you don't need to close this PR. Update the PR whichever changes requested by @ykdojo

@subhoghoshX
Copy link
Collaborator

LGTM. Make the changes that YK mentioned and make sure to run it through a grammar checker like Grammarly or Quillbot.

@jideabdqudus
Copy link
Contributor Author

LGTM. Make the changes that YK mentioned and make sure to run it through a grammar checker like Grammarly or Quillbot.

Changes have been made & I did the spell check as well cc @rohitdasu @ykdojo

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@iShibi iShibi linked an issue Aug 15, 2022 that may be closed by this pull request
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ykdojo
Copy link
Collaborator

ykdojo commented Aug 15, 2022

^Once you address the comments I added above, I think it looks good to me.

I'll wait for one or two more reviewers to check it, though.

@iShibi
Copy link
Contributor

iShibi commented Aug 16, 2022

You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading.

Also, write a note for the contributors to checkout a feature branch before working on a PR instead of adding changes in the main branch directly.

@jideabdqudus
Copy link
Contributor Author

You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading.

Also, write a note for the contributors to checkout a feature branch before working on a PR instead of adding changes in the main branch directly.

Can you give more context to what you mean here?

@veganaize
Copy link
Contributor

veganaize commented Aug 18, 2022

You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading.
Also, write a note for the contributors to checkout a feature branch before working on a PR instead of adding changes in the main branch directly.

Can you give more context to what you mean here?

@jideabdqudus I think they mean you should move the contributing related stuff, from README.md, into CONTRIBUTING.md.

For their second request, about creating a new feature branch for each PR, you might reference the following document:
https://github.com/LibreSprite/LibreSprite/blob/master/CONTRIBUTING.md#making-changes

@jideabdqudus
Copy link
Contributor Author

You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading.
Also, write a note for the contributors to checkout a feature branch before working on a PR instead of adding changes in the main branch directly.

Can you give more context to what you mean here?

@jideabdqudus I think they mean you should move the contributing related stuff, from README.md, into CONTRIBUTING.md.

For their second request, about creating a new feature branch for each PR, you might reference the following document: https://github.com/LibreSprite/LibreSprite/blob/master/CONTRIBUTING.md#making-changes

I got this,

For the first request, stuff from README.md are already in here. Then I added content explaining the steps in making changes.

@veganaize
Copy link
Contributor

veganaize commented Aug 19, 2022

You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading.

For the first request, stuff from README.md are already in here. Then I added content explaining the steps in making changes.

@jideabdqudus Can you remove the entire "How to contribute" section from README.md and place it inside of CONTRIBUTING.md, link to CONTRIBUTING.md from README.md, and push that?

@jideabdqudus
Copy link
Contributor Author

You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading.

For the first request, stuff from README.md are already in here. Then I added content explaining the steps in making changes.

@jideabdqudus Can you remove the entire "How to contribute" section from README.md and place it inside of CONTRIBUTING.md, link to CONTRIBUTING.md from README.md, and push that?

Okay that makes sense, I just did with the new push

@veganaize
Copy link
Contributor

veganaize commented Aug 19, 2022

@jideabdqudus Can you remove the entire "How to contribute" section from README.md and place it inside of CONTRIBUTING.md, link to CONTRIBUTING.md from README.md, and push that?

Okay that makes sense, I just did with the new push

I could be wrong but it looks like you've removed the "How to contribute" section from CONTRIBUTING.md and not from README.md? It should be the other way around. [Sorry if my crossed out comment confused you.]

@jideabdqudus
Copy link
Contributor Author

@jideabdqudus Can you remove the entire "How to contribute" section from README.md and place it inside of CONTRIBUTING.md, link to CONTRIBUTING.md from README.md, and push that?

Okay that makes sense, I just did with the new push

I could be wrong but it looks like you've removed the "How to contribute" section from CONTRIBUTING.md and not from README.md? It should be the other way around. [Sorry if my crossed out comment confused you.]

Oh Dang, you lost me a bit. I've reverted this and fixed README.md

@veganaize
Copy link
Contributor

Oh Dang, you lost me a bit. I've reverted this and fixed README.md

Sorry... my bad @jideabdqudus !

This all looks good, to me. What do you think @ykdojo , @rohitdasu , and @iShibi ?

Copy link
Collaborator

@ykdojo ykdojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to CONTRIBUTING.md from README.md?

@rohitdasu
Copy link
Contributor

Can you add a link to CONTRIBUTING.md from README.md?

yes agree, should have a link to CONTRIBUTING.md

@jideabdqudus
Copy link
Contributor Author

Okay guys, back to this :).
I've added a link to CONTRIBUTING.md from README.md with the latest push.
Can we once go through the file so I wouldn't have to make little changes again @ykdojo @rohitdasu @iShibi

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 21, 2022

Thank you so much! Looks good to me.

@iShibi
Copy link
Contributor

iShibi commented Aug 22, 2022

@jideabdqudus looks good. Resolve the git conflicts by rebasing and then we will merge it.

@iShibi iShibi changed the title dx: created and wrote CONTRIBUTING.md file dx: add CONTRIBUTING.md file Aug 22, 2022
@vercel
Copy link

vercel bot commented Aug 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 10:26AM (UTC)

@jideabdqudus
Copy link
Contributor Author

@jideabdqudus looks good. Resolve the git conflicts by rebasing and then we will merge it.

Feel free to merge now

@iShibi
Copy link
Contributor

iShibi commented Aug 22, 2022

You overwrote the changes made in the main. I'll have to rebase it and then we can merge.

@iShibi iShibi merged commit 6f7f8f4 into csdojo-defaang:main Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants