-
-
Notifications
You must be signed in to change notification settings - Fork 120
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel. @ykdojo first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but it's a lot to review in one go.
Any chance you could break it down to much smaller pieces and send individual PRs for them?
Do I close this PR and send new PRs as individual chunks? Or how do I go about this |
Hi @jideabdqudus you don't need to close this PR. Update the PR whichever changes requested by @ykdojo |
LGTM. Make the changes that YK mentioned and make sure to run it through a grammar checker like Grammarly or Quillbot. |
Changes have been made & I did the spell check as well cc @rohitdasu @ykdojo |
^Once you address the comments I added above, I think it looks good to me. I'll wait for one or two more reviewers to check it, though. |
You should move the content inside https://github.com/ykdojo/defaang#how-to-contribute into this file and then link this file under that sub-heading. Also, write a note for the contributors to checkout a feature branch before working on a PR instead of adding changes in the |
Can you give more context to what you mean here? |
@jideabdqudus I think they mean you should move the contributing related stuff, from For their second request, about creating a new feature branch for each PR, you might reference the following document: |
I got this, For the first request, stuff from README.md are already in here. Then I added content explaining the steps in making changes. |
@jideabdqudus Can you remove the entire "How to contribute" section from |
Okay that makes sense, I just did with the new push |
I could be wrong but it looks like you've removed the "How to contribute" section from |
Oh Dang, you lost me a bit. I've reverted this and fixed README.md |
Sorry... my bad @jideabdqudus ! This all looks good, to me. What do you think @ykdojo , @rohitdasu , and @iShibi ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to CONTRIBUTING.md from README.md?
yes agree, should have a link to CONTRIBUTING.md |
Okay guys, back to this :). |
Thank you so much! Looks good to me. |
@jideabdqudus looks good. Resolve the git conflicts by rebasing and then we will merge it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Feel free to merge now |
You overwrote the changes made in the |
afc224e
to
3faa622
Compare
Closes #71