Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The high/low frequency issue. #35

Closed
kukabu opened this issue Oct 18, 2016 · 6 comments
Closed

The high/low frequency issue. #35

kukabu opened this issue Oct 18, 2016 · 6 comments

Comments

@kukabu
Copy link
Contributor

kukabu commented Oct 18, 2016 •
edited
Loading

Hello

Some satellite in SatNOGS DB have only UP_HIGH/DOWN_HIGH and gpredict doesn't work with it.
Is it a bug in SatNOGS DB or gpredict?

https://db.satnogs.org/satellite/41313/
@kukabu
Copy link
Contributor Author

kukabu commented Oct 18, 2016

hm... I found the same in local files https://github.com/csete/gpredict/blob/master/data/trsp/25509.trsp

@LongnoseRob
Copy link
Contributor

Did you try this whis the latest version?
I also found some issues with the satelite data and it was fixed already..

Maybe reimporting the TRSP data from SatNogs will help..

@kukabu
Copy link
Contributor Author

kukabu commented Oct 18, 2016

the latest version

@csete
Copy link
Owner

csete commented Oct 18, 2016

Thanks for the info.

Previously trsp files were created manually and validated before becoming integral part of the package. Now we are in a new situation where data comes from external sources and we have to be able to handle all sorts of data.

I am in the process of cleaning up the side effects of the new trsp importer and also change the way we manage frequency data internally, but I am going to need some time to finish. But keep posting issues you find.

csete added a commit that referenced this issue Oct 18, 2016
@csete
Store frequencies as int64 instead of double.
bf66478 
Also add some sanity checks to ensure that we can handle various
scenarios where either limit of up- or downlink is not specified, see
issue #35.

The calculations in rig-ctrl are stil ldone using double.
@csete
Copy link
Owner

csete commented Oct 18, 2016

Please try it now. The code should now be robust for various missing parts of transponder data. You are also welcome to test it with manually edited files.

It was a late night commit but I hope I didn't ruin anything :-)

@kukabu
Copy link
Contributor Author

kukabu commented Oct 19, 2016

Fixed. Thank!

@kukabu kukabu closed this as completed Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csete @kukabu @LongnoseRob