Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VFO mode in Rigctrl. Gpredict will now try to enable … #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KaComet
Copy link
Contributor

@KaComet KaComet commented Nov 28, 2022

…and use VFO mode, usually set via the --vfo command line flag in Rigctrl, when connecting to a radio. If VFO mode could not be enabled, the old style of commanding the radio is used.

Why is this needed:

@mdblack98 has indicated that Gpredict should move to default to VFO mode.

Changes that impact the users

  • Users will now have to define the VFOs for the manual and auto modes, just like users of the full-duplex mode.

Testing:

All radio modes (full duplex, RX only, ect) were tested on an FT-736R, IC-9700, FT-991A. Additionally, I have been using this version of Gpredict for my personal use for approximately 1 week. I have not encountered any issues. Rigctrl version: rigctl Hamlib 4.6~git Mon Nov 28 22:45:08 2022 +0000 SHA=e2570d

Testing results:

FT-991A:

  • All modes working as intended. Testing with VFO mode forcefully disabled resulted in all modes working as intended. Testing with the half-duplex mode required some workarounds because the radio does not support switching bands while transmitting.

IC-9700:

  • All modes working as intended. Testing with VFO mode forcefully disabled resulted in all modes working as intended. Testing with the half-duplex mode required some workarounds because the radio does not support switching bands while transmitting.

FT-736R:

  • All modes working as intended. Testing with VFO mode forcefully disabled resulted in all modes working as intended. Testing with the half-duplex mode required some workarounds because the radio does not support switching bands while transmitting.

Additional relevant testing data will be provided on request.

…and use VFO mode, usally set via the --vfo command line flag in Rigctrl, when connecting to a radio. If VFO mode could not be enabled, the old style of commanding the radio is used.
@mdblack98
Copy link
Contributor

Try the latest hamlib from the master repo. I put a patch in for the 736 that should set VFOB correctly.
https://github.com/Hamlib/Hamlib

@KaComet
Copy link
Contributor Author

KaComet commented Nov 29, 2022

@mdblack98, latest Hamlib commit resolved issues with the FT-736R. Testing results have been updated. I appreciate your assistance. Hamlib version: rigctl Hamlib 4.6~git Mon Nov 28 22:45:08 2022 +0000 SHA=e2570d

@csete
Copy link
Owner

csete commented Dec 24, 2023

Hi @KaKomet

Thanks for the improvement and sorry for the late followup. I wanted to merge this but there are now some conflicts that I am unsure about how to resolve. Could you see if you can resolve them?

Thanks
Alex

@mdblack98
Copy link
Contributor

What conflicts?

@csete
Copy link
Owner

csete commented Dec 24, 2023

Sorry, I forgot that only I can see the merge conflict info.

I have tried to resolve the conflicts and pushed the code to the hamlibvfo branch. If it looks okay, I can merge it these changes manually.

@KaComet
Copy link
Contributor Author

KaComet commented Dec 24, 2023

@csete, thanks for taking a look. For reference, this PR is my implementation of mdblack's suggestion that GPredict should prefer to use VFO mode in Hamlib. You can find the original discussion regarding the use of VFO mode under #287 . While mdblack originally made #316 to implement VFO mode. Unfortunately, I found that this PR did not correctly implement VFO mode and broke compatibility with all of the radios I tested it with. After some testing, the discussion of which can be found in the comments under #316, I submitted this PR with code that implements VFO mode.

I have tested this code of multiple radios and modes. Currently, I use this PR's changes for my everyday satellite endeavors. I even used these changes during this year's ARRL field day. You can see my testing data in the original PR comment.

I can take a look over the next few days and verify that the rig control loop works correctly under the resolved branch. I'll keep you updated with my results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants