Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate appearances can be selected on Match Edit page #10

Closed
grahammcculloch opened this issue May 16, 2018 · 0 comments
Closed

Duplicate appearances can be selected on Match Edit page #10

grahammcculloch opened this issue May 16, 2018 · 0 comments
Assignees
@grahammcculloch
Labels
defect
Milestone
AWS Release

Comments

@grahammcculloch
Copy link
Contributor

To reproduce: click twice in quick succession on a player to add them to the list of appearances. This is possible because of the animation which means the component isn't removed immediately.

Need to disable the click action after the first click.
@grahammcculloch grahammcculloch added this to the AWS Release milestone May 16, 2018
@grahammcculloch grahammcculloch self-assigned this May 16, 2018
grahammcculloch added a commit that referenced this issue May 16, 2018
@grahammcculloch
#10 Prevent duplicate addition of appearances
9fba488 
Refactored the potential player into its own React Component and used the state to prevent any action being taken if the user clicks multiple times in quick succession.

Also added similar logic to the 'Add new member' button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grahammcculloch grahammcculloch

Labels
defect
Projects
None yet
Milestone
AWS Release
Development

No branches or pull requests
1 participant
@grahammcculloch