Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move InAppMessaging into a sub-category under Notifications #6

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

cshfang
Copy link
Owner

@cshfang cshfang commented Oct 13, 2021

Description of changes

This PR refactors the Notifications category to be a root level category which contains a InAppMessaging sub-category

Description of how you validated changes

Manually tested with local React Native app

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor comments

packages/notifications/src/types.ts Outdated Show resolved Hide resolved
@cshfang cshfang merged commit c78ce59 into in-app-messages Oct 13, 2021
@cshfang cshfang deleted the sub-categorize-in-app-messaging branch October 13, 2021 19:38
cshfang pushed a commit that referenced this pull request Oct 15, 2021
feature: add clearStoredInAppMessages method
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server amplify-help forum.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants