Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisualizeDataProcess.lithology_layer_process is not data column independent #19

Open
jmp75 opened this issue Sep 1, 2019 · 1 comment
Open

VisualizeDataProcess.lithology_layer_process is not data column independent #19

jmp75 opened this issue Sep 1, 2019 · 1 comment

Comments

@jmp75
Copy link
Collaborator

jmp75 commented Sep 1, 2019

Reviewing / testing a contribution for pyvista use. Some of the code has hard coded use of 'x' and 'y' for column names expected in the data frame.
@jmp75
Copy link
Collaborator Author

jmp75 commented Sep 1, 2019

gi = GridInterpolation(easting_col='x', northing_col='y') is the problem line. Trying to design a unit test is complicated by the top entry function taking data paths as agruments. IO should be dealt with elsewhere.

jmp75 added a commit that referenced this issue Sep 1, 2019
@jmp75
temporary work around issue #19
3c89dea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmp75