Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kairos-crypto fixes #134

Merged
merged 3 commits into from
Jun 27, 2024
Merged

kairos-crypto fixes #134

merged 3 commits into from
Jun 27, 2024

Conversation

koxu1996
Copy link
Contributor

This PR contains 2 simple fixes:

  • 41ec4fa - allow constructing signer from public key without fs feature - moved to core trait
  • 56e2f12 - no_std compatibility for kairos-tx built with tx feature enabled - disabled default features for dependency

@koxu1996 koxu1996 self-assigned this Jun 24, 2024
@Avi-D-coder
Copy link
Contributor

I would love to see a different modeling other than Option<PrivateKey>, but this works so approved.

@koxu1996 koxu1996 merged commit 55be47c into main Jun 27, 2024
4 checks passed
@koxu1996 koxu1996 deleted the feature/crypto-improvements branch June 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas089 jonas089 jonas089 approved these changes

@Avi-D-coder Avi-D-coder Avi-D-coder approved these changes

@marijanp marijanp Awaiting requested review from marijanp

Assignees

@koxu1996 koxu1996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koxu1996 @Avi-D-coder @jonas089