-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kairos server test hook #49
Conversation
|
||
impl Drop for Kairos { | ||
fn drop(&mut self) { | ||
let _ = self.process_handle.kill(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: This is not a graceful shutdown, but for testing it seems to be okay.
.spawn() | ||
.expect("Failed to start the kairos-server"); | ||
|
||
wait_for_port(url.socket_addrs(|| Option::None).unwrap().first().unwrap()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: In the future we should introduce healtcheck mechanism - for example /health
endpoint - because open port does not mean that server is ready to process requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go back to stable Rust, then I have no other concerns about this PR.
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6ffd7a9 |
No description provided.