Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: don't follow our nixpkgs revision for risc0pkgs to speedup builds #84

Merged
merged 7 commits into from
May 24, 2024

Conversation

marijanp
Copy link
Contributor

@marijanp marijanp commented Apr 29, 2024

  • I removed the follows instruction such that we trigger less rebuilds for the risc0 tooling if we update nixpkgs and benefit from better caching
  • I updated the kairos-prover to follow the risc0pkgs template
  • I packaged the kairos-prover with crane
  • I refactored the source filtering for kairos, making it easier to use and likely willl improve caching because it's less error prone

Further temporary optimisation:

  • uncomment the import of ./kairos-prover to avoid building any risc0 related code
  • removed the GHA ubuntu build
  • removed the GHA x86_64-darwin build

Note that prior to merging we need to change the merge rules to not require the ubuntu-latest check.

Copy link

github-actions bot commented Apr 29, 2024

File Coverage
All files 54%
kairos-tx/src/asn.rs 76%
kairos-tx/src/error.rs 0%
kairos-server/src/routes/deposit.rs 88%
kairos-server/src/routes/transfer.rs 90%
kairos-server/src/config.rs 0%
kairos-server/src/errors.rs 12%
kairos-server/src/state.rs 90%
kairos-server/src/utils.rs 22%
kairos-crypto/src/implementations/casper.rs 3%
kairos-test-utils/src/cctl/parsers.rs 66%
kairos-server/src/state/transactions.rs 57%
kairos-server/src/state/trie.rs 35%
kairos-test-utils/src/cctl.rs 87%
kairos-test-utils/src/kairos.rs 95%
kairos-server/tests/transactions.rs 85%
kairos-server/src/state/transactions/batch_state.rs 42%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against f8122c3

@marijanp marijanp requested a review from Avi-D-coder May 14, 2024 21:37
@marijanp marijanp marked this pull request as ready for review May 14, 2024 21:37
@marijanp marijanp self-assigned this May 21, 2024
@marijanp marijanp merged commit 5170bd7 into main May 24, 2024
4 checks passed
@marijanp marijanp deleted the ci-optim branch May 24, 2024 12:59
@@ -0,0 +1,6636 @@
# This file is automatically @generated by Cargo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: where is TOML file used to generate this lockfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is none because rust-std only ships with a lockfile: I don't know how you obtain your rust compiler but there should be a directory lib/rustlib/src/rust and this is where this fiel is copied from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants