Reduce enum noise #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The enum implementation that was generated shares a lot of boilerplate among other enums and generally results in an implementation that has a lot of noise around it compared to what we want to achieve. To reduce the visual clutter in generated enums much of the functionality was moved out into an EnumTrait. - Instead of returning an arbitrary toString() we are now simply returning the string representation (i.e. method name used to instantiate your enum instance) of the enum that was generated. This is more inline with our Java inspiration and is also more intuitive to use in places where you might want to show or use the string representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enum implementation that was generated shares a lot of boilerplate
among other enums and generally results in an implementation that has a
lot of noise around it compared to what we want to achieve. To reduce
the visual clutter in generated enums much of the functionality was
moved out into an EnumTrait.
Instead of returning an arbitrary toString() we are now simply
returning the string representation (i.e. method name used to
instantiate your enum instance) of the enum that was generated. This is
more inline with our Java inspiration and is also more intuitive to use
in places where you might want to show or use the string representation.