Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new plugin for text-decoration-skip-ink property #69

Merged
merged 8 commits into from
Feb 8, 2019

Conversation

AleshaOleg
Copy link
Member

No description provided.

@kof
Copy link
Member

kof commented Feb 6, 2019

Test failed, is the test wrong or the code?

@AleshaOleg
Copy link
Member Author

AleshaOleg commented Feb 6, 2019

@kof actually code is wrong :( I thought -webkit- prefix will work for both cases (Safari and Chrome). But according to autoprefixer, Chrome doesn't need prefix and Safari requires it. Don't know for now how to deal with it

@AleshaOleg
Copy link
Member Author

@kof please check solution.

I decided to detect Safari via appleTrailingWord property.
Also can't detect for some reason this property via hasOwnProperty or in. That's why I wrote this line with Object.keys().

screen shot 2019-02-07 at 12 41 02 am

@kof
Copy link
Member

kof commented Feb 7, 2019

'-apple-trailing-word' in document.createElement('p').style

works

@kof
Copy link
Member

kof commented Feb 7, 2019

since you are not detecting safari, you are detecting apple as a vendor, mb better to call it vendor and 'apple' as a value

@kof
Copy link
Member

kof commented Feb 7, 2019

I mean potentially it could be other browser using webkit fork with this apple specific property

@AleshaOleg
Copy link
Member Author

Just pushed updates

@AleshaOleg
Copy link
Member Author

@kof could you please check it again? I pushed required changes

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AleshaOleg AleshaOleg merged commit 0d03be3 into master Feb 8, 2019
@AleshaOleg AleshaOleg deleted the autoprefixer-update branch February 9, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants