Fix SSR for Hooks based implementation #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kof
commented
Jul 2, 2019
kof
commented
- registry now returns all sheets from .toString() by default, not only attached, since conditional rendering is not possible on the server
- on the client you can pass now .toString({attached: true}) to get only attached sheets, we assume use cases doing that on the client are rare
HenriBeck
approved these changes
Jul 2, 2019
HenriBeck
pushed a commit
that referenced
this pull request
Jul 6, 2019
* master: (50 commits) v10.0.0-alpha.22 add react-dom dev dependenncy Fix SSR for Hooks based implementation (#1148) React-JSS id prop docs and improvements (#1147) v10.0.0-alpha.21 fix changelog add support hint to the changelog (#1145) Sheets management for css() (#1137) Update css-vendor to 2.0.5 (#1142) more articles Small readability improvements (#1138) create sponsors.md (#1139) update karma settings Update css-vendor to 2.0.4 (#1136) v10.0.0-alpha.20 fixing release v10.0.0-alpha.19 fix lerna force-publish flag many more tests and some improvements to styped interface (#1133) v10.0.0-alpha.18 ... # Conflicts: # packages/react-jss/src/index.d.ts
HenriBeck
pushed a commit
that referenced
this pull request
Jul 7, 2019
* master: Use componentDidMount for WithStyles (#1157) Use mui like global ponyfill (#1153) HOC should not attach sheets until mount (#1149) v10.0.0-alpha.22 add react-dom dev dependenncy Fix SSR for Hooks based implementation (#1148) React-JSS id prop docs and improvements (#1147) v10.0.0-alpha.21 fix changelog add support hint to the changelog (#1145) Sheets management for css() (#1137) # Conflicts: # packages/react-jss/.size-snapshot.json
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* registry.toString returns all by default and accepts attached option * changelog and docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.