fix: Cannot read property rules of undefined #1189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtereshyn
changed the title
|
I think the problem is somewhere before. |
vtereshyn
changed the title
matteoferigo
added a commit
to matteoferigo/jss
that referenced
this pull request
Nov 6, 2019
|
With this change, the issue will appear later (eg: rules is used even in row To fix this issue is simply needed to prevent rules update when rule instance doesn't exist anymore |
|
closing this PR since it isn't mergeable, please feel free to reopen later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it works for you, but I guess we shouldn't come into this condition if
ruleis undefined