Fixes sheet ordering #819
Fixes sheet ordering #819
Conversation
| const {registry} = sheets | ||
|
|
||
| if (registry.length > 0) { | ||
| // Try to insert before the next higher sheet. | ||
| let sheet = findHigherSheet(registry, options) | ||
| if (sheet) return sheet.renderer.element | ||
| if (sheet) { | ||
| return { |
There was a problem hiding this comment.
Seems like calling parentNode in advance doesn't bring much value other than makes findPrevNode semantics wrong. Mb I oversee something but to me it looks like we could keep the return value as it was.
There was a problem hiding this comment.
The problem is when returning nextSibling and when it returns null we can't get the parentNode
There was a problem hiding this comment.
Arent you appending in the end of the head when nextSibling is null?
There was a problem hiding this comment.
Not necessarily, it was supposed to work with appending it at the end of the parent of the stylesheet
| @@ -268,7 +289,7 @@ function insertStyle(style: HTMLElement, options: PriorityOptions) { | |||
| return | |||
| } | |||
|
|
|||
| getHead().insertBefore(style, prevNode) | |||
There was a problem hiding this comment.
it worked basically before same way, because the insertBefore api allows to pass prevNode === null and it will be inserted in the end of the parent, so the same as appendChild
There was a problem hiding this comment.
seems a bit simpler to me
|
We should have supported an insertion point as node as the only argument, I think this would simplify it. |
|
I don't think it would simplify much because the only code which could be removed is: https://github.com/cssinjs/jss/blob/master/packages/jss/src/renderers/DomRenderer.js#L235-L243 |
* Added failing test for the ordering issue * Added fix for the issue * Update size-snapshots * Fix tests
Fixes the sheet ordering as described in #816
prevNodereturns now an object becausenextSiblingmay return null when it's the last element which results in not being able to get the parent for the insertion.