Rewrite filterProps and createStyled, fix tests #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
reviewed
Apr 30, 2017
src/createStyled.js
Outdated
| const getStyledElementAttrs = ( | ||
| tagNameOrStyledElement: TagNameOrStyledElementType | ||
| ): StyledElementAttrsType => (typeof tagNameOrStyledElement === 'string' | ||
| ? {tagName: tagNameOrStyledElement, style: {}} |
There was a problem hiding this comment.
we should avoid multiline ternaries, they are hard to read
There was a problem hiding this comment.
doesn't jss linter shows an error in this case?
lttb
force-pushed
the
feature/optimize-performance
branch
from
e00cee5
to
e81fb39
Compare
lttb
force-pushed
the
feature/optimize-performance
branch
from
e81fb39
to
f74298d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.