Add support for useTheme hook #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2019 10:09
added 2 commits
February 6, 2019 10:25
* master: Update changelog Fix tests Fix flow Improve bundle size
TrySound
approved these changes
Feb 6, 2019
|
Missing the docs |
kof
reviewed
Feb 10, 2019
README.md
Outdated
| @@ -218,6 +219,25 @@ export default App; | |||
|
|
|||
| The `withTheme` HOC supports the new React forwardRef API so you can just use the normal ref prop. | |||
|
|
|||
| ### Use theme (Hook) | |||
There was a problem hiding this comment.
just call it useTheme so that it matches the hash in TOC
|
Alright, updated the docs |
added 2 commits
February 10, 2019 20:39
…s-support * origin/add-hooks-support: Update README.md
kof
approved these changes
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As hooks are now in a stable release, I added a small util function for getting the theme inside functional components.