fix: handle 2 color-stop-length in linear-gradient #1215
Conversation
| @@ -74,7 +74,9 @@ function optimise(decl) { | |||
| !isFinalStop && | |||
| lastStop && | |||
| lastStop.number === '0' && | |||
| lastStop.unit.toLowerCase() !== 'deg' | |||
| lastStop.unit.toLowerCase() !== 'deg' && | |||
There was a problem hiding this comment.
I would suggest to revert these changes and instead change line 63 to
if (arg.length !== 3) {
All of the existing processing assumes the one-stop syntax (it expects [something, space, something] as arg
There was a problem hiding this comment.
Then background:linear-gradient(#ffe500 0% 0%,#121 100%) => background:linear-gradient(#121) would be ignored but i think this is justified.
I change the code again today.
There was a problem hiding this comment.
Changed the code as you suggested now, the case i mentioned is unhandled.
goulashsoup
force-pushed
the
postcss-minify-gradients-2-color-stop-length
branch
2 times, most recently
from
f208a95
to
f2f12cc
Compare
goulashsoup
force-pushed
the
postcss-minify-gradients-2-color-stop-length
branch
from
f2f12cc
to
ff8a9eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 116 116
Lines 3614 3614
Branches 1064 1064
=======================================
Hits 3489 3489
Misses 117 117
Partials 8 8
Continue to review full report at Codecov.
|
fixes #1205