Fixup broken buttons, styling changes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylendog
commented
Feb 29, 2024
Comment on lines
+31
to
+38
| <ThemeContext.Provider value={{ lightMode, setLightMode }}> | ||
| <html lang="en"> | ||
| <body className={inter.className}> | ||
| <Navbar /> | ||
| {children} | ||
| </body> | ||
| </html> | ||
| </ThemeContext.Provider> |
There was a problem hiding this comment.
We need to move the context provider into the root layout, otherwise it only exists for /
kaylendog
commented
Feb 29, 2024
Comment on lines
-12
to
-39
| export function set_username(username: string) {console.log(username)} //placeholder | ||
|
|
||
| export function handleUsernameSubmit(usernameState: string) { | ||
| set_username(usernameState); | ||
| } | ||
|
|
||
| export function handleUsernameChange(e: React.FormEvent<HTMLInputElement>, setUsernameState: React.Dispatch<React.SetStateAction<string>>) { | ||
|
|
||
| console.log("test") | ||
| setUsernameState(e.currentTarget.value); | ||
|
|
||
| } | ||
|
|
||
| export function set_bio(bio: string) {} //placeholder | ||
|
|
||
| export function handleBioSubmit(bioState: string) { | ||
| set_bio(bioState); | ||
| } | ||
|
|
||
| export function handleBioChange(e: React.FormEvent<HTMLTextAreaElement>, setBioState: React.Dispatch<React.SetStateAction<string>>) { | ||
|
|
||
| setBioState(e.currentTarget.value); | ||
|
|
||
| } | ||
|
|
||
| export function toggleLightMode(lightMode: boolean) { | ||
| //backend call | ||
| } |
There was a problem hiding this comment.
These will all be hooks with rspc.useQuery, so can go for now.
kaylendog
commented
Feb 29, 2024
| </div> | ||
|
|
||
| <form |
There was a problem hiding this comment.
<form> is the de-facto way of handling input forms in HTML. We could use react-form or similar, but that's effort.
kaylendog
commented
Feb 29, 2024
Comment on lines
+13
to
+14
| "@faker-js/faker": "^8.4.1", | ||
| "@tanstack/react-virtual": "^3.1.3", |
There was a problem hiding this comment.
These weren't in package.json and breaks a clean install without them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<form>for input, it's tidier