Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: uncomment Requires for smatch #36

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Aug 15, 2023

The smatch package is now available in Fedora.

Related: https://src.fedoraproject.org/rpms/smatch

@lzaoral lzaoral requested a review from kdudka August 15, 2023 10:18
@lzaoral lzaoral self-assigned this Aug 15, 2023
@lzaoral
Copy link
Member Author

lzaoral commented Aug 15, 2023

I'll undraft the PR when all builds for Fedora and EPEL will be finished.

@lzaoral lzaoral marked this pull request as ready for review August 15, 2023 12:15
@lzaoral
Copy link
Member Author

lzaoral commented Aug 15, 2023

Hmm, the EPEL 7 Copr job hit the same issue as my Copr builds of smatch did:

CMake Error at /usr/share/cmake3/Modules/CMakeTestCCompiler.cmake:60 (message):
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /builddir/build/BUILD/cscppc-2.2.4.20230815.112413.g2be0c91.pr_36/ppc64le-redhat-linux-gnu/CMakeFiles/CMakeTmp
    
    Run Build Command(s):/usr/bin/gmake cmTC_4c3c6/fast && /usr/bin/gmake  -f CMakeFiles/cmTC_4c3c6.dir/build.make CMakeFiles/cmTC_4c3c6.dir/build
    gmake[1]: Entering directory `/builddir/build/BUILD/cscppc-2.2.4.20230815.112413.g2be0c91.pr_36/ppc64le-redhat-linux-gnu/CMakeFiles/CMakeTmp'
    Building C object CMakeFiles/cmTC_4c3c6.dir/testCCompiler.c.o
    /usr/bin/cc   -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches   -m64 -mcpu=power8 -mtune=power8    -o CMakeFiles/cmTC_4c3c6.dir/testCCompiler.c.o   -c /builddir/build/BUILD/cscppc-2.2.4.20230815.112413.g2be0c91.pr_36/ppc64le-redhat-linux-gnu/CMakeFiles/CMakeTmp/testCCompiler.c
    cc: warning: '-mcpu=' is deprecated; use '-mtune=' or '-march=' instead
    /builddir/build/BUILD/cscppc-2.2.4.20230815.112413.g2be0c91.pr_36/ppc64le-redhat-linux-gnu/CMakeFiles/CMakeTmp/testCCompiler.c:1:0: error: bad value (power8) for -mtune= switch
     #ifdef __cplusplus
     ^
    gmake[1]: *** [CMakeFiles/cmTC_4c3c6.dir/testCCompiler.c.o] Error 1
    gmake[1]: Leaving directory `/builddir/build/BUILD/cscppc-2.2.4.20230815.112413.g2be0c91.pr_36/ppc64le-redhat-linux-gnu/CMakeFiles/CMakeTmp'
    gmake: *** [cmTC_4c3c6/fast] Error 2
    
    

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:19 (project)

@lzaoral
Copy link
Member Author

lzaoral commented Aug 15, 2023

Copr issue: fedora-copr/copr#2875

The smatch package is now available in Fedora.

Related: https://src.fedoraproject.org/rpms/smatch
@lzaoral
Copy link
Member Author

lzaoral commented Sep 12, 2023

/packit rebuild-failed

make-srpm.sh Outdated Show resolved Hide resolved
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@lzaoral lzaoral merged commit 7711275 into csutils:main Sep 12, 2023
5 of 20 checks passed
@lzaoral lzaoral deleted the enable-csmatch branch September 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants