Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML5 instead of XHTML 1.0 🌍 #179

Merged
merged 1 commit into from
May 13, 2024
Merged

Use HTML5 instead of XHTML 1.0 🌍 #179

merged 1 commit into from
May 13, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 10, 2024

Note

UTF-8 is the default encoding in HTML5

@jamacku jamacku linked an issue May 10, 2024 that may be closed by this pull request
cshtml: use HTML5 instead of XHTML 🍳 #177
Closed
@jamacku jamacku requested a review from lzaoral May 10, 2024 10:06
@jamacku jamacku mentioned this pull request May 10, 2024
Merged
lzaoral
lzaoral approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I quite sure that this is safe but let's wait for @kdudka's review as well.

kdudka
kdudka approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamacku Looks good, thanks! I have only tweaked the commit message.

@jamacku jamacku merged commit 44952ad into csutils:main May 13, 2024
33 checks passed
@jamacku jamacku deleted the html5 branch May 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdudka kdudka kdudka approved these changes

@lzaoral lzaoral lzaoral approved these changes

Assignees
No one assigned
Labels
enhancement html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cshtml: use HTML5 instead of XHTML 🍳
3 participants
@jamacku @kdudka @lzaoral