Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some HTML related warnings found by HTMLLint ✔️ #180

Merged
merged 2 commits into from
May 14, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 10, 2024

No description provided.

@jamacku jamacku linked an issue May 10, 2024 that may be closed by this pull request
@lzaoral
Copy link
Member

lzaoral commented May 10, 2024

Thank you @jamacku! W3C HTML validator shows following warnings:

Warning: The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.

[From line 7, column 37; to line 8, column 15](https://validator.w3.org/nu/#l8c15)

re-wrap;'>↩<a name='def1'></a><b

It should be quite easy to replace name with id as suggested in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#name

@jamacku
Copy link
Member Author

jamacku commented May 10, 2024

@lzaoral Good point, resolved in 64372ac

@jamacku jamacku marked this pull request as ready for review May 10, 2024 10:05
@jamacku jamacku requested a review from lzaoral May 10, 2024 10:06
@kdudka kdudka self-requested a review May 13, 2024 15:19
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@jamacku jamacku merged commit 63871e2 into csutils:main May 14, 2024
33 checks passed
@jamacku jamacku deleted the htmllint branch May 14, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cshtml: fix HTMLLint 🌵
3 participants