Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few test warnings #902

Merged
merged 4 commits into from Dec 18, 2018
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 14, 2018

No description provided.

@maxnoe maxnoe requested review from kosack and dneise December 14, 2018 09:04
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #902 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         186      186           
  Lines       10867    10867           
=======================================
  Hits         8965     8965           
  Misses       1902     1902
Impacted Files Coverage Δ
ctapipe/analysis/camera/chargeresolution.py 85.04% <100%> (ø) ⬆️
ctapipe/utils/tests/test_datasets.py 100% <100%> (ø) ⬆️
ctapipe/reco/tests/test_energy_regressor.py 100% <100%> (ø) ⬆️
ctapipe/reco/tests/test_event_classifier.py 100% <100%> (ø) ⬆️
ctapipe/image/muon/features.py 75.86% <100%> (ø) ⬆️
...apipe/reco/tests/test_regressor_classifier_base.py 93.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a6797...e4696cc. Read the comment docs.

@maxnoe maxnoe requested a review from a team December 15, 2018 11:08
@thomasgas thomasgas self-requested a review December 18, 2018 08:53
@thomasgas thomasgas merged commit 16457f0 into cta-observatory:master Dec 18, 2018
watsonjj added a commit to watsonjj/ctapipe that referenced this pull request Jan 7, 2019
* master: (22 commits)
  Remove all hillas_paramters but version 5, fixes cta-observatory#866  (cta-observatory#904)
  Fix docstring of EventSeeker, fixes cta-observatory#768 (cta-observatory#914)
  Do not set autodownload, fixes doc build (cta-observatory#910)
  Import bokeh.palletes correctly, fixes cta-observatory#911 (cta-observatory#912)
  Fix SST-1M to be DC and not SC. Solves cta-observatory#905 (cta-observatory#908)
  Fix a few test warnings (cta-observatory#902)
  Updates of NectarCam and LSTCam real data eventsource class (cta-observatory#812)
  Implemented FACT image cleaning (cta-observatory#862)
  remove `config=None, tool=None` in some tests (cta-observatory#897)
  Remove flow submodule (got moved to its own package) (cta-observatory#893)
  Cleaning the ctapipe folder. this has been empty for 3 years. (cta-observatory#892)
  Additional metadata from pyhessio, similar to cta-observatory#655 (cta-observatory#895)
  add scikit-learn to install_requires (cta-observatory#877)
  Add .mailmap (cta-observatory#894)
  Fix subarray peek. No more warnings. (cta-observatory#841)
  SimTelEventSource using pyeventio (cta-observatory#864)
  Use sparse neighbor matrix (cta-observatory#826)
  Add test how it should be (cta-observatory#842)
  fix errordef > 0. (cta-observatory#839)
  Fix warning about already closed hessio file (cta-observatory#834)
  ...

# Conflicts:
#	ctapipe/analysis/camera/chargeresolution.py
#	ctapipe/tools/extract_charge_resolution.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants