fixed two problems that prevented DL3 generation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) tel_combo was read as a float but used a index, and required cast to int this is a bit dangerous but it seems to be only used for the metadata 2) list of telescopes was passed as an array, but instead should be a string
|
Hi @jsitarek, thanks for reporting. I looked into this, and pushed one commit to slightly change the solution. Now the |
YoshikiOhtani
approved these changes
Oct 5, 2022
Elisa-Visentin
pushed a commit
that referenced
this pull request
Sep 12, 2024
fixed two problems that prevented DL3 generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@YoshikiOhtani can you have a look?
the first problem actually would be better to be solved already earlier: saving those combinations as int and not float