Fix an issue that wrong LST-1 events are extracted as coincident events #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elisa-Visentin
pushed a commit
that referenced
this pull request
Sep 12, 2024
Fix an issue that wrong LST-1 events are extracted as coincident events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry but the pull request #109, which is already merged to the master branch, introduced a critical bug in the event coincidence search. I realized that it extracted completely wrong LST-1 events as coincident events (by wrongly selected indices
indices_lst), so with this pull request I fix the issue. Also, I added the missing code to assign LST observation and event IDs to coincident MAGIC events, as the MAGIC IDs are assigned to coincident LST-1 events.