Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch the numpy LinAlgError when recostructing the stereo parameters. #189

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

aleberti
Copy link
Collaborator

Closes #125

@aleberti aleberti added the maintenance Maintenance related label Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4b9908) 76.83% compared to head (1cec705) 76.83%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   76.83%   76.83%           
=======================================
  Files          21       21           
  Lines        2556     2556           
=======================================
  Hits         1964     1964           
  Misses        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jsitarek jsitarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if you catch such an event with a problem it will skip the calculation of remaining stereo parameters and saving them into the output for this event, therefore the Hillas parameters will be still there, but stereo parameters will have 'NaN'. This could potentially cause some issues later on in the code (e.g. when filling in data for RF), but the same was applied before for non valid stereoscopic reconstruction and I checked in recent files that I had such NaNs, but no problems in RF stage, but I guess they are automatically removed there. So perfectly fine the way how you did it.

@aleberti aleberti merged commit 8389708 into master Feb 9, 2024
8 checks passed
@aleberti aleberti deleted the exclude_events_linalg_error branch February 9, 2024 16:29
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Catch the numpy LinAlgError when recostructing the stereo parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skipping events giving singular matrix in hillar_reconstructor
2 participants