-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thermal tests + CI in DQM #122
Conversation
One thing that needs to be fixed before accepting this pull request is the path to the data file used for the tests. @jlenain can you point me to the one you mentioned yesterday? |
There are a few such instances throughout
|
@hashkar , one thing that I am wondering is whether the DQM module is the best place for thermal test analyses. In my understanding, the DQM should run a quality monitoring as generic as possible. A dedicated analysis of runs for thermal tests would be better placed into |
@jlenain I totally agree. The DQM module is still the same I just changed small things in it to be able to compute the quantities needed for the thermal tests easily. These quantities are also useful for the DQM (for example pedestal averaged for the first 20 samples). In the user_script there will be the script to launch the thermal tests and analyze + plot the results. |
I guess the prints were meant to assess which value to assert the tests. Could you please remove these? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes may be redundant with PR #148 , or adjusted accordingly. We'll take care of that when merging the two PRs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 40.76% 48.63% +7.86%
==========================================
Files 65 64 -1
Lines 4452 4581 +129
==========================================
+ Hits 1815 2228 +413
+ Misses 2637 2353 -284 ☔ View full report in Codecov by Sentry. |
This pull request contains changes to make the DQM easily usable for the thermal tests.
The main changes also include the integration of CI tests for the DQM.
This is just an initiation to the CI tests. They are not complete yet. The first function of each class is tested here.