Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda env #27

Merged
merged 11 commits into from
Jan 25, 2023
Merged

Fix conda env #27

merged 11 commits into from
Jan 25, 2023

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Jan 10, 2023

The proposed PR, along with cta-observatory/ctapipe_io_nectarcam#32, should address #26, and streamline the installation procedure of nectarchain.

 - Install ctapipe_io_nectarcam automatically as dependency
 - Fix the installation of the fts3 dependency for DIRAC
 - Reflect these changes in the recipe for Singularity
@frnbrun
Copy link
Contributor

frnbrun commented Jan 10, 2023

Hi @jlenain , following the installation steps in the branch you provided for this PR, the following error occurs when trying to read a data file :
FileNotFoundError: [Errno 2] No such file or directory: /Users/fbrun/anaconda2/envs/nectarchain_pr27_env/lib/python3.8/site-packages/ctapipe_io_nectarcam/resources/NectarCam-003.camgeom.fits.gz'

In fact, the whole "resources" folder from ctapipe_io_nectarcam is not included in the created environment. Do you know why ?

@jlenain
Copy link
Collaborator Author

jlenain commented Jan 10, 2023

Hi @jlenain , following the installation steps in the branch you provided for this PR, the following error occurs when trying to read a data file : FileNotFoundError: [Errno 2] No such file or directory: /Users/fbrun/anaconda2/envs/nectarchain_pr27_env/lib/python3.8/site-packages/ctapipe_io_nectarcam/resources/NectarCam-003.camgeom.fits.gz'

In fact, the whole "resources" folder from ctapipe_io_nectarcam is not included in the created environment. Do you know why ?

Hi @frnbrun!
Ah, good point. In order to benefit from cta-observatory/ctapipe_io_nectarcam#32 at the same time, one should also install ctapipe_io_nectarcam from my branch in my fork before the PR is merged there.

One way to do it is to slightly change the installation procedure for ctapipe_io_nectarcam in the environment.yml file for nectarchain with:

  - pip:
      - git+https://github.com/jlenain/ctapipe_io_nectarcam.git@improve-setup

Re-fix another typo
For DIRAC support, forgot to instruct to deactivate/re-activate the conda environment in order to propagate the declarations of `$X509...` she'll variables.
@frnbrun
Copy link
Contributor

frnbrun commented Jan 11, 2023

Thanks for the feedback, @jlenain (I now get some warning about the fact that ctapipe_io_nectarcam do not have a proper version number but I guess it is normal since I took it from one of your branch)

I managed to install nectarchain following the steps from the new procedure. I then tried the notebook notebooks/Access NectarCAM data using DIRAC API.ipynb and it worked nicely!

I just have a few questions :

  • do we still need to have the environment-dirac.yml file ? If not, maybe the notebook I tried could be updated since it would be mentioning an outdated installation procedure ?
  • the dirac-configure command "contain" the dirac-proxy-init one ? Is it possible to specify from dirac-configure the "nectarcam" role ?

@jlenain
Copy link
Collaborator Author

jlenain commented Jan 11, 2023

Hi @frnbrun !

(I now get some warning about the fact that ctapipe_io_nectarcam do not have a proper version number but I guess it is normal since I took it from one of your branch)

As long as we don't tag the ctapipe_io_nectarcam module, this warning is normal, whatever the origin.

I just have a few questions :

* do we still need to have the environment-dirac.yml file ? If not, maybe the notebook I tried could be updated since it would be mentioning an outdated installation procedure ?

You're right, we would not need the specific environment-dirac.yml any more. I will propose a removal of it through this PR, and update the notebook accordingly.

* the `dirac-configure` command "contain" the `dirac-proxy-init` one ? Is it possible to specify from `dirac-configure` the "nectarcam" role ?

The dirac-configure command comes from DIRAC itself, and is just a one-time helper to configure a DIRAC client from a given instance (the CTA one, in our case). At this stage, there is no need to initialize a proxy with a specific role.

I hope this covers your questions.

…e instructions on the notebook showcasing how to interface DIRAC and nectarchain.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jlenain jlenain requested a review from frnbrun January 11, 2023 22:46
@jlenain jlenain added the bug Something isn't working label Jan 11, 2023
@jlenain jlenain linked an issue Jan 11, 2023 that may be closed by this pull request
Copy link
Contributor

@frnbrun frnbrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications @jlenain

@jlenain
Copy link
Collaborator Author

jlenain commented Jan 19, 2023

Holding merge until cta-observatory/ctapipe_io_nectarcam#32 is accepted and merged into ctapipe_io_nectarcam.

@jlenain jlenain linked an issue Jan 24, 2023 that may be closed by this pull request
@jlenain
Copy link
Collaborator Author

jlenain commented Jan 25, 2023

cta-observatory/ctapipe_io_nectarcam#32 is now merged, merging this PR as well.

@jlenain jlenain merged commit dedc3af into cta-observatory:master Jan 25, 2023
@jlenain jlenain deleted the fix-conda-env branch January 25, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytables 3.7 needed Flawed environment due to PEP-660
2 participants