Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTAMARS-like energy estimation #156

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Fix CTAMARS-like energy estimation #156

merged 5 commits into from
Aug 3, 2021

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Jul 27, 2021

Closes #148

NOTE: the method getRMS in ROOT actually performs the standard deviation (see e.g. https://root.cern.ch/root/html534/TH1.html#TH1:GetRMS)

@HealthyPear HealthyPear added wrong behaviour The code works but produces clearly wrong results fix A PR that fixes a bug or a wrong behaviour. energy estimation Anything related to the model and its application labels Jul 27, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Jul 27, 2021
@HealthyPear HealthyPear added this to In progress in Bugs and wrong behaviours via automation Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #156 (6f89fb3) into master (e1ce3e6) will increase coverage by 0.11%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   66.14%   66.25%   +0.11%     
==========================================
  Files          24       24              
  Lines        2283     2291       +8     
==========================================
+ Hits         1510     1518       +8     
  Misses        773      773              
Impacted Files Coverage Δ
protopipe/scripts/data_training.py 93.21% <85.71%> (+0.12%) ⬆️
protopipe/scripts/write_dl2.py 82.25% <85.71%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ce3e6...6f89fb3. Read the comment docs.

@HealthyPear HealthyPear requested a review from kosack July 28, 2021 09:49
@HealthyPear HealthyPear merged commit 02f4b91 into master Aug 3, 2021
Bugs and wrong behaviours automation moved this from In progress to Closed Aug 3, 2021
@HealthyPear HealthyPear deleted the fix_issue_148 branch August 3, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
energy estimation Anything related to the model and its application fix A PR that fixes a bug or a wrong behaviour. wrong behaviour The code works but produces clearly wrong results
Projects
Development

Successfully merging this pull request may close these issues.

Current "STD" estimation weight method is not the same as in CTAMARS analysis
2 participants