New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation + general maintenance #62
Update documentation + general maintenance #62
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 36.81% 37.03% +0.21%
==========================================
Files 18 19 +1
Lines 1798 1801 +3
==========================================
+ Hits 662 667 +5
+ Misses 1136 1134 -2
Continue to review full report at Codecov.
|
@@ -2,7 +2,7 @@ | |||
"cells": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to look into later why this is different (not sure anyone has ever really tested the shower-max reco), but since the reconstructed event selection is also different, it's not too bad.
Reply via ReviewNB
docs/contribute/benchmarks/TRAINING/benchmarks_DL2_to_classification.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes in the notebooks. Otherwise looks nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can re-approve when you make the necessary doc updates
Summary description
Requirements