Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update to installation instructions #107

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Small update to installation instructions #107

merged 2 commits into from
Oct 30, 2020

Conversation

HealthyPear
Copy link
Member

No description provided.

Core dependencies are

* ``numpy``
* ``astropy``
* ``scipy``

Dependencies for development, like unit tests and building the documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

It is required that the python environment contains also ``cython`` before
installing pyirf.

The dependencies required to perform unit-testing and to build the documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah moved, sorry, I think this is fine!

docs/install.rst Outdated Show resolved Hide resolved
docs/install.rst Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          36       36           
  Lines        1201     1201           
=======================================
  Hits         1072     1072           
  Misses        129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21253a...21132c8. Read the comment docs.

@maxnoe maxnoe merged commit f1f29bd into master Oct 30, 2020
@maxnoe maxnoe deleted the fix-installation branch October 30, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants