Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture containing some prod5 irfs from zenodo #211

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Conversation

RuneDominik
Copy link
Member

@RuneDominik RuneDominik commented Feb 8, 2023

This intends to add a fixture for future unit-testing containing some of the prod5 irfs published on zenodo. Since downloading the files each time a new github action is triggered is time-consuming we try to cache things using github's action/cache.

ATM this PR is intended to do some live-testing with github's CI. I undraft it once everything works.
Edit: Everything should be working now

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 91.05% // Head: 91.08% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2c51a34) compared to base (0c3abf6).
Patch coverage: 94.11% of modified lines in pull request are covered.

❗ Current head 2c51a34 differs from pull request most recent head 20afc01. Consider uploading reports for the commit 20afc01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   91.05%   91.08%   +0.03%     
==========================================
  Files          41       43       +2     
  Lines        1699     1716      +17     
==========================================
+ Hits         1547     1563      +16     
- Misses        152      153       +1     
Impacted Files Coverage Δ
pyirf/conftest.py 92.85% <92.85%> (ø)
pyirf/tests/test_resources.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@maxnoe
Copy link
Member

maxnoe commented Feb 8, 2023

These files should also be added to gitignore or stored in a place outside the repo

@RuneDominik RuneDominik marked this pull request as ready for review February 8, 2023 16:48
@maxnoe maxnoe merged commit 4d55170 into master Feb 9, 2023
@maxnoe maxnoe deleted the irf_test_fixture branch February 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants