Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove I/O in the event loop when creating client #596

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

ctalkington
Copy link
Owner

@ctalkington ctalkington commented Aug 15, 2023

@ctalkington ctalkington added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #596 (d0395d6) into main (ac9c599) will increase coverage by 0.02%.
Report is 13 commits behind head on main.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   96.06%   96.09%   +0.02%     
==========================================
  Files           7        7              
  Lines         432      435       +3     
  Branches       85       86       +1     
==========================================
+ Hits          415      418       +3     
  Misses          4        4              
  Partials       13       13              
Files Changed Coverage Δ
src/rokuecp/resolver.py 89.47% <0.00%> (ø)
src/rokuecp/__init__.py 100.00% <100.00%> (ø)
src/rokuecp/helpers.py 89.28% <100.00%> (+0.19%) ⬆️
src/rokuecp/models.py 95.97% <100.00%> (ø)
src/rokuecp/rokuecp.py 98.52% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctalkington ctalkington merged commit c3fdff8 into main Aug 15, 2023
16 checks passed
@ctalkington ctalkington deleted the ctalkington-patch-1 branch August 15, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant