Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Picker cannot decrease #7

Closed
ericcitaire opened this issue Aug 23, 2013 · 3 comments
Closed

Time Picker cannot decrease #7

ericcitaire opened this issue Aug 23, 2013 · 3 comments

Comments

@ericcitaire
Copy link

When minutes are greater than zero (ie. 45) and the user try to decrease the time using arrows or the mouse-wheel on the minutes field, it stops decreasing (ie. at 00:45).

This is due to a condition in decreaseValue(), which seems to intend to block the decreasing at 00:00. It doesn't work and I think it's not necessary to block at 00:00. BTW, the same condition in increaseValue() doesn't work either. I suggest we drop these conditions.

ericcitaire added a commit to ericcitaire/GWT-Eureka that referenced this issue Aug 23, 2013
@ctasada
Copy link
Owner

ctasada commented Aug 28, 2013

Hi Eric,

Thanks for reporting this bug, but for some reason I cannot replicate it. Can you give me an step by step replication? Is happening in all browsers? can you replicate using http://gwt-eureka.appspot.com?

I've applied your patch, but I don't see any change in the behaviour.

Thanks again

@ericcitaire
Copy link
Author

Hi,

Yes, you can replicate the bug on http://gwt-eureka.appspot.com/. The easiest way is to decrease the minutes with the mouse-wheel in the first Small TimePicker example (it's easier because it decreases faster). Decrease it until you get 00:45, and then you're stuck here.

I was able to reproduce this in Chrome, Firefox and IE.

Eric.

ctasada added a commit that referenced this issue Sep 9, 2013
@ctasada
Copy link
Owner

ctasada commented Sep 9, 2013

Thanks a lot Eric, it worked like a charm!

@ctasada ctasada closed this as completed Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants